From ce5bbfc8c0e1a928cfa24f206cc65286514230e2 Mon Sep 17 00:00:00 2001
From: "Karl O. Pinc" <kop@karlpinc.com>
Date: Mon, 30 Sep 2024 09:16:18 -0500
Subject: [PATCH] Attach onchange event of upload SQL checkbox with javascript
 instead of HTML

---
 src/pgwui_sql/static/sql_edit.js     | 9 +++++++--
 src/pgwui_sql/templates/sql_edit.mak | 1 -
 2 files changed, 7 insertions(+), 3 deletions(-)

diff --git a/src/pgwui_sql/static/sql_edit.js b/src/pgwui_sql/static/sql_edit.js
index 9a069b5..6d86a3e 100644
--- a/src/pgwui_sql/static/sql_edit.js
+++ b/src/pgwui_sql/static/sql_edit.js
@@ -37,9 +37,10 @@ function showSearchPath() {
         window.alert('Problem showing the search_path: ' + error);
         })
 };
-function toggleSqlUsed(elem) {
+
+function toggleSqlUsed() {
   sql_text = document.getElementById('sql_id');
-  if (elem.checked) {
+  if (this.checked) {
     sql_text.style.backgroundColor = '#ececec';
   } else {
     sql_text.style.backgroundColor = '';
@@ -83,6 +84,10 @@ function attachEvents() {
     expand_eol_info.addEventListener("keydown", toggleEOLInfoRow);
     collapse_eol_info.addEventListener("keydown", toggleEOLInfoRow);
 
+    /* Upload SQL selection */
+    document.getElementById('upload_sql_id')
+        .addEventListener("change", toggleSqlUsed);
+
     /* Tab-delimited help */
     document.getElementById('tab_delimited_help_id')
         .addEventListener("click", () =>
diff --git a/src/pgwui_sql/templates/sql_edit.mak b/src/pgwui_sql/templates/sql_edit.mak
index 44137c5..d876e8a 100644
--- a/src/pgwui_sql/templates/sql_edit.mak
+++ b/src/pgwui_sql/templates/sql_edit.mak
@@ -127,7 +127,6 @@
                  tabindex="${tab_index.val}"
                  id="upload_sql_id"
                  type="checkbox"
-                 onchange="toggleSqlUsed(this);"
                  ${upload_sql}
                  />
         </%self.lib:td_input>
-- 
2.34.1