From b5ed7151350fbbf31ce4dec52b8de20817d7c0bf Mon Sep 17 00:00:00 2001
From: "Karl O. Pinc" <kop@karlpinc.com>
Date: Sat, 3 Aug 2024 15:43:25 -0500
Subject: [PATCH] Add label id targets back to input labels

As it turns out, you can't use "for" as an argument/tag element attribute
with mako.  At least not when inheriting the namespace into templates
at arbitrary depth.
---
 src/pgwui_common/templates/auth_base.mak | 4 ++--
 src/pgwui_common/templates/db_base.mak   | 2 +-
 src/pgwui_common/templates/lib.mak       | 9 +++++++--
 3 files changed, 10 insertions(+), 5 deletions(-)

diff --git a/src/pgwui_common/templates/auth_base.mak b/src/pgwui_common/templates/auth_base.mak
index c017d31..eb92dbc 100644
--- a/src/pgwui_common/templates/auth_base.mak
+++ b/src/pgwui_common/templates/auth_base.mak
@@ -97,7 +97,7 @@
 
 <%def name="user_row(tab_index, havecreds, user)">
       <tr>
-        <%self.lib:td_label>Username</%self.lib:td_label>
+        <%self.lib:td_label for_id="user_id">Username</%self.lib:td_label>
           % if havecreds:
             <td><span id="user_id">${user}</span></td>
           % else:
@@ -117,7 +117,7 @@
 <%def name="password_row(tab_index, havecreds)">
       % if not havecreds:
         <tr>
-          <%self.lib:td_label>Password</%self.lib:td_label>
+          <%self.lib:td_label for_id="password_id">Password</%self.lib:td_label>
           <%self.lib:td_input tab_index="${tab_index}">
             <input name="password"
                    tabindex="${tab_index.val}"
diff --git a/src/pgwui_common/templates/db_base.mak b/src/pgwui_common/templates/db_base.mak
index 5bd818d..ec7a99e 100644
--- a/src/pgwui_common/templates/db_base.mak
+++ b/src/pgwui_common/templates/db_base.mak
@@ -66,7 +66,7 @@
 
 <%def name="database_row(tab_index)">
   <tr>
-    <%self.lib:td_label>Database</%self.lib:td_label>
+    <%self.lib:td_label for_id="db_id">Database</%self.lib:td_label>
     <%self.lib:td_input tab_index="${tab_index}">
       <input name="db"
              tabindex="${tab_index.val}"
diff --git a/src/pgwui_common/templates/lib.mak b/src/pgwui_common/templates/lib.mak
index 398a311..97e2dbf 100644
--- a/src/pgwui_common/templates/lib.mak
+++ b/src/pgwui_common/templates/lib.mak
@@ -38,9 +38,14 @@
 
 ## Table data
 
-<%def name="td_label()">
+<%def name="td_label(for_id=None)">
         <td class="label">
-          <label for="user_id">${capture(caller.body) | trim}:</label>
+          <%
+            for_attr = ''
+            if for_id is not None:
+              for_attr = f'for="{for_id}"'
+          %>
+          <label ${for_attr}>${capture(caller.body) | trim}:</label>
         </td>
 </%def>
 
-- 
2.34.1