From 85da5864821ff2e1fa3f9fe30655f6a0a0b9b05a Mon Sep 17 00:00:00 2001 From: "Karl O. Pinc" Date: Tue, 16 Jul 2024 07:48:16 -0500 Subject: [PATCH] Better response variable name db_changed -> report_success --- src/pgwui_sql/views/sql.py | 2 +- tests/views/test_sql.py | 8 ++++---- 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/src/pgwui_sql/views/sql.py b/src/pgwui_sql/views/sql.py index 4ed7d65..f24eab5 100644 --- a/src/pgwui_sql/views/sql.py +++ b/src/pgwui_sql/views/sql.py @@ -46,7 +46,7 @@ def sql_view(request): response.setdefault('pgwui', dict()) response['pgwui']['pgwui_sql'] = settings['pgwui']['pgwui_sql'] - if response['db_changed']: + if response['report_success']: if pgwui_core.core.is_checked(response['csv_checked']): upload_fmt = 'CSV' else: diff --git a/tests/views/test_sql.py b/tests/views/test_sql.py index 974bcec..f783c15 100644 --- a/tests/views/test_sql.py +++ b/tests/views/test_sql.py @@ -46,7 +46,7 @@ DEFAULT_URLS = {'pgwui_sql': '/sql', CHANGED_RESPONSE = { 'db': 'somedb', - 'db_changed': True, + 'report_success': True, 'filename': 'file', 'lines': 5, 'null_rep': 'NULL', @@ -56,7 +56,7 @@ CHANGED_RESPONSE = { 'user': 'someuser', } -UNCHANGED_RESPONSE = {'db_changed': False} +UNCHANGED_RESPONSE = {'report_success': False} # Helper classes @@ -123,7 +123,7 @@ def test_upload_view_db_not_changed(return_log_tuples): assert log_tuples == [] -def test_upload_view_db_changed_csv(return_log_tuples): +def test_upload_view_report_success_csv(return_log_tuples): '''When the db did change from CSV input something logs''' response = CHANGED_RESPONSE response['csv_checked'] = constants.CHECKED @@ -134,7 +134,7 @@ def test_upload_view_db_changed_csv(return_log_tuples): == [('pgwui_sql.views.sql', logging.INFO)]) -def test_upload_view_db_changed_no_csv(return_log_tuples): +def test_upload_view_report_success_no_csv(return_log_tuples): '''When the db did change from not-CSV input something logs''' response = CHANGED_RESPONSE response['csv_checked'] = constants.UNCHECKED -- 2.34.1