From 74179d3b7484c6a920ea94e1fa12382fe0f69271 Mon Sep 17 00:00:00 2001
From: "Karl O. Pinc" <kop@karlpinc.com>
Date: Sat, 3 Aug 2024 14:35:53 -0500
Subject: [PATCH] Abstract table data input element

---
 src/pgwui_common/templates/auth_base.mak | 26 +++++++++++-------------
 src/pgwui_common/templates/db_base.mak   |  5 ++---
 src/pgwui_common/templates/lib.mak       |  5 +++++
 3 files changed, 19 insertions(+), 17 deletions(-)

diff --git a/src/pgwui_common/templates/auth_base.mak b/src/pgwui_common/templates/auth_base.mak
index 6c11cd8..c017d31 100644
--- a/src/pgwui_common/templates/auth_base.mak
+++ b/src/pgwui_common/templates/auth_base.mak
@@ -98,20 +98,19 @@
 <%def name="user_row(tab_index, havecreds, user)">
       <tr>
         <%self.lib:td_label>Username</%self.lib:td_label>
-        <td>
           % if havecreds:
-            <span id="user_id">${user}</span>
+            <td><span id="user_id">${user}</span></td>
           % else:
-            <input name="user"
-                   tabindex="${tab_index.val}"
-                   id="user_id"
-                   type="text"
-                   size="30"
-                   value=""
-                   />
+            <%self.lib:td_input tab_index="${tab_index}">
+              <input name="user"
+                     tabindex="${tab_index.val}"
+                     id="user_id"
+                     type="text"
+                     size="30"
+                     value=""
+                     />
+            </%self.lib:td_input>
           % endif
-          <% tab_index.inc() %>
-        </td>
       </tr>
 </%def>
 
@@ -119,16 +118,15 @@
       % if not havecreds:
         <tr>
           <%self.lib:td_label>Password</%self.lib:td_label>
-          <td>
+          <%self.lib:td_input tab_index="${tab_index}">
             <input name="password"
                    tabindex="${tab_index.val}"
                    id="password_id"
                    type="password"
                    size="30"
                    />
-          </td>
+          </%self.lib:td_input>
         </tr>
-        <% tab_index.inc() %>
       % endif
 </%def>
 
diff --git a/src/pgwui_common/templates/db_base.mak b/src/pgwui_common/templates/db_base.mak
index b4f258b..5bd818d 100644
--- a/src/pgwui_common/templates/db_base.mak
+++ b/src/pgwui_common/templates/db_base.mak
@@ -67,7 +67,7 @@
 <%def name="database_row(tab_index)">
   <tr>
     <%self.lib:td_label>Database</%self.lib:td_label>
-    <td>
+    <%self.lib:td_input tab_index="${tab_index}">
       <input name="db"
              tabindex="${tab_index.val}"
              id="db_id"
@@ -75,9 +75,8 @@
              size="30"
              value="${db}"
              />
-    </td>
+    </%self.lib:td_input>
   </tr>
-  <% tab_index.inc() %>
 </%def>
 
 <%def name="table_rows(tab_index)">
diff --git a/src/pgwui_common/templates/lib.mak b/src/pgwui_common/templates/lib.mak
index 2824d57..81da801 100644
--- a/src/pgwui_common/templates/lib.mak
+++ b/src/pgwui_common/templates/lib.mak
@@ -43,3 +43,8 @@
           <label for="user_id">${capture(caller.body) | trim}:</label>
         </td>
 </%def>
+
+<%def name="td_input(tab_index)">
+        <td>${caller.body()}</td>
+        <% tab_index.inc() %>
+</%def>
-- 
2.34.1